Backport of:

From a29723ce1af75eed0813c3717d3f6dee9b405ca8 Mon Sep 17 00:00:00 2001
From: Eric Covener <covener@apache.org>
Date: Wed, 3 Apr 2024 12:10:49 +0000
Subject: [PATCH] let httpd handle CL/TE for non-http handlers

backport r1916769 from trunk:
Submitted By: ylavic, covener



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1916777 13f79535-47bb-0310-9956-ffa450edef68
---
 include/util_script.h           |  2 ++
 modules/aaa/mod_authnz_fcgi.c   |  8 ++++++++
 modules/generators/mod_cgi.c    | 15 ++++++++++++---
 modules/generators/mod_cgid.c   | 15 ++++++++++++---
 modules/http/http_filters.c     | 12 ++++++++++++
 modules/proxy/ajp_header.c      | 10 ++++++++++
 modules/proxy/mod_proxy_fcgi.c  |  9 +++++++++
 modules/proxy/mod_proxy_scgi.c  |  8 ++++++++
 modules/proxy/mod_proxy_uwsgi.c |  6 ++++++
 9 files changed, 79 insertions(+), 6 deletions(-)

Index: apache2-2.4.29/include/util_script.h
===================================================================
--- apache2-2.4.29.orig/include/util_script.h
+++ apache2-2.4.29/include/util_script.h
@@ -225,6 +225,8 @@ AP_DECLARE(int) ap_scan_script_header_er
  */
 AP_DECLARE(void) ap_args_to_table(request_rec *r, apr_table_t **table);
 
+#define AP_TRUST_CGILIKE_CL_ENVVAR "ap_trust_cgilike_cl"
+
 #ifdef __cplusplus
 }
 #endif
Index: apache2-2.4.29/modules/aaa/mod_authnz_fcgi.c
===================================================================
--- apache2-2.4.29.orig/modules/aaa/mod_authnz_fcgi.c
+++ apache2-2.4.29/modules/aaa/mod_authnz_fcgi.c
@@ -571,6 +571,14 @@ static apr_status_t handle_response(cons
                                       "parsing -> %d/%d",
                                       fn, status, r->status);
 
+                        /* FCGI has its own body framing mechanism which we don't
+                         * match against any provided Content-Length, so let the
+                         * core determine C-L vs T-E based on what's actually sent.
+                         */
+                        if (!apr_table_get(r->subprocess_env, AP_TRUST_CGILIKE_CL_ENVVAR))
+                            apr_table_unset(r->headers_out, "Content-Length");
+                        apr_table_unset(r->headers_out, "Transfer-Encoding");
+
                         if (rspbuf) { /* caller wants to see response body,
                                        * if any
                                        */
Index: apache2-2.4.29/modules/generators/mod_cgi.c
===================================================================
--- apache2-2.4.29.orig/modules/generators/mod_cgi.c
+++ apache2-2.4.29/modules/generators/mod_cgi.c
@@ -939,9 +939,18 @@ static int cgi_handler(request_rec *r)
         char sbuf[MAX_STRING_LEN];
         int ret;
 
-        if ((ret = ap_scan_script_header_err_brigade_ex(r, bb, sbuf,
-                                                        APLOG_MODULE_INDEX)))
-        {
+        ret = ap_scan_script_header_err_brigade_ex(r, bb, sbuf,
+                                                   APLOG_MODULE_INDEX);
+
+        /* xCGI has its own body framing mechanism which we don't
+         * match against any provided Content-Length, so let the
+         * core determine C-L vs T-E based on what's actually sent.
+         */
+        if (!apr_table_get(r->subprocess_env, AP_TRUST_CGILIKE_CL_ENVVAR))
+            apr_table_unset(r->headers_out, "Content-Length");
+        apr_table_unset(r->headers_out, "Transfer-Encoding");
+
+        if (ret != OK) {
             ret = log_script(r, conf, ret, dbuf, sbuf, bb, script_err);
 
             /*
Index: apache2-2.4.29/modules/generators/mod_cgid.c
===================================================================
--- apache2-2.4.29.orig/modules/generators/mod_cgid.c
+++ apache2-2.4.29/modules/generators/mod_cgid.c
@@ -1618,9 +1618,18 @@ static int cgid_handler(request_rec *r)
         b = apr_bucket_eos_create(c->bucket_alloc);
         APR_BRIGADE_INSERT_TAIL(bb, b);
 
-        if ((ret = ap_scan_script_header_err_brigade_ex(r, bb, sbuf,
-                                                        APLOG_MODULE_INDEX)))
-        {
+        ret = ap_scan_script_header_err_brigade_ex(r, bb, sbuf,
+                                                   APLOG_MODULE_INDEX);
+
+        /* xCGI has its own body framing mechanism which we don't
+         * match against any provided Content-Length, so let the
+         * core determine C-L vs T-E based on what's actually sent.
+         */
+        if (!apr_table_get(r->subprocess_env, AP_TRUST_CGILIKE_CL_ENVVAR))
+            apr_table_unset(r->headers_out, "Content-Length");
+        apr_table_unset(r->headers_out, "Transfer-Encoding");
+
+        if (ret != OK) {
             ret = log_script(r, conf, ret, dbuf, sbuf, bb, NULL);
 
             /*
Index: apache2-2.4.29/modules/http/http_filters.c
===================================================================
--- apache2-2.4.29.orig/modules/http/http_filters.c
+++ apache2-2.4.29/modules/http/http_filters.c
@@ -774,6 +774,19 @@ static APR_INLINE int check_headers(requ
     struct check_header_ctx ctx;
     core_server_config *conf =
             ap_get_core_module_config(r->server->module_config);
+    const char *val;
+ 
+    if ((val = apr_table_get(r->headers_out, "Transfer-Encoding"))) {
+        if (apr_table_get(r->headers_out, "Content-Length")) {
+            apr_table_unset(r->headers_out, "Content-Length");
+            r->connection->keepalive = AP_CONN_CLOSE;
+        }
+        if (!strcasecmp(val, "chunked") == 0 /* fast path */
+                 && !ap_find_last_token(r->pool, val, "chunked")) {
+            r->connection->keepalive = AP_CONN_CLOSE;
+            return 0;
+        }
+    }
 
     ctx.r = r;
     ctx.strict = (conf->http_conformance != AP_HTTP_CONFORMANCE_UNSAFE);
Index: apache2-2.4.29/modules/proxy/ajp_header.c
===================================================================
--- apache2-2.4.29.orig/modules/proxy/ajp_header.c
+++ apache2-2.4.29/modules/proxy/ajp_header.c
@@ -17,6 +17,8 @@
 #include "ajp_header.h"
 #include "ajp.h"
 
+#include "util_script.h"
+
 APLOG_USE_MODULE(proxy_ajp);
 
 static const char *response_trans_headers[] = {
@@ -662,6 +664,14 @@ static apr_status_t ajp_unmarshal_respon
         }
     }
 
+    /* AJP has its own body framing mechanism which we don't
+     * match against any provided Content-Length, so let the
+     * core determine C-L vs T-E based on what's actually sent.
+     */
+    if (!apr_table_get(r->subprocess_env, AP_TRUST_CGILIKE_CL_ENVVAR))
+        apr_table_unset(r->headers_out, "Content-Length");
+    apr_table_unset(r->headers_out, "Transfer-Encoding");
+
     return APR_SUCCESS;
 }
 
Index: apache2-2.4.29/modules/proxy/mod_proxy_fcgi.c
===================================================================
--- apache2-2.4.29.orig/modules/proxy/mod_proxy_fcgi.c
+++ apache2-2.4.29/modules/proxy/mod_proxy_fcgi.c
@@ -725,6 +725,15 @@ recv_again:
 
                             status = ap_scan_script_header_err_brigade_ex(r, ob,
                                 NULL, APLOG_MODULE_INDEX);
+
+                            /* FCGI has its own body framing mechanism which we don't
+                             * match against any provided Content-Length, so let the
+                             * core determine C-L vs T-E based on what's actually sent.
+                             */
+                            if (!apr_table_get(r->subprocess_env, AP_TRUST_CGILIKE_CL_ENVVAR))
+                                apr_table_unset(r->headers_out, "Content-Length");
+                            apr_table_unset(r->headers_out, "Transfer-Encoding");
+
                             /* suck in all the rest */
                             if (status != OK) {
                                 apr_bucket *tmp_b;
Index: apache2-2.4.29/modules/proxy/mod_proxy_scgi.c
===================================================================
--- apache2-2.4.29.orig/modules/proxy/mod_proxy_scgi.c
+++ apache2-2.4.29/modules/proxy/mod_proxy_scgi.c
@@ -388,6 +388,14 @@ static int pass_response(request_rec *r,
         return status;
     }
 
+    /* SCGI has its own body framing mechanism which we don't
+     * match against any provided Content-Length, so let the
+     * core determine C-L vs T-E based on what's actually sent.
+     */
+    if (!apr_table_get(r->subprocess_env, AP_TRUST_CGILIKE_CL_ENVVAR))
+        apr_table_unset(r->headers_out, "Content-Length");
+    apr_table_unset(r->headers_out, "Transfer-Encoding");
+
     conf = ap_get_module_config(r->per_dir_config, &proxy_scgi_module);
     if (conf->sendfile && conf->sendfile != scgi_sendfile_off) {
         short err = 1;
